MySQL Stored Proc comment parsing

[expired user #10269]'s profile image [expired user #10269] posted 7 years ago in General Permalink

I've been evaluating HeidiSQL as a possible replacement for our current MySQL GUI, and hit a major problem: When there are comments embedded in the parameter list, regardless of which comment syntax is used, Heidi misparses it badly. It looks like there's also an issue with ENUM types, due to the embedded commas. The proc is created correctly on the first run, but the parameter and create tabs are incorrect, as you can see from the attached -- a snip of the relevant part of the original .sql file, the results in Heidi's CREATE Code tab, and the results in the Parameters tab. Not shown, because only three attachments, but the results of running "SHOW CREATE" are correct; it's only the Heidi UI misparsing -- but that includes the parameter prompts when you use "Run routine(s)".

3 attachment(s):
  • original-create
  • heidi-create
  • heidi-params
[expired user #10269]'s profile image [expired user #10269] posted 7 years ago Permalink

Anything? I like Heidi overall, but this is a showstopper for us.

[expired user #10292]'s profile image [expired user #10292] posted 7 years ago Permalink

This is the only real flaw I've seen in HeidiSQL so far. Can we please get this fixed?

ansgar's profile image ansgar posted 7 years ago Permalink

Oh, believe me, this is not the only one :) But yes, I'll see if I can fix the parsing expressions.

[expired user #10269]'s profile image [expired user #10269] posted 7 years ago Permalink

Any update or timeline on when this might get fixed? I don't want my team to have to switch tools repeatedly, so it will probably be at least a year before we revisit this, once we choose our next tool.

jaksal's profile image jaksal posted 2 years ago Permalink

This problem is still fixed, can you please fix it?

ansgar's profile image ansgar posted 2 years ago Permalink

Sorry for the long delay.

The problem was also reported in issue #1477, and it's fixed now. The next nightly builds strips comments from parameters away before parsing them.

Please login to leave a reply, or register at first.