Unsafe Queries Found - Esc or Close window says "YES"

[expired user #9489]'s profile image [expired user #9489] posted 8 years ago in General Permalink

Hey thanks for your product, it is much better than any other tool that I've used, I've converted some in our office over to use it :)

I'm not sure if this is a bug or a suggestion. But I just found out that when I run an "unsafe query" I have this great option presented to me. Since panic over takes me, I don't know what Yes or No means, only that I don't want to run the query. I stared at it for a minute contemplating the options. "I could kill the process and certainly not run it" I thought, but then I thought I would lose my query. "certainly the esc key then is safe with a dialog like this" so I pressed it only to see that the query did run! Yikes!! Fortunately I was able to kill the query before any destruction happened. Phew!!

So I have this proposal: Change the esc, small X (close button) to cancel the query run. And perhaps change the labeling to something more explicit, such as "Run query" and "Don't run"

Attached is a my best art on the topic

Thanks much!!

Run build 4984 on Windows 7

1 attachment(s):
  • run-unsafe-query
[expired user #9489]'s profile image [expired user #9489] posted 8 years ago Permalink

By the way, the feature is helpful as if the warning was not there I probably would not have noticed and the query would have caused great woe!

ansgar's profile image ansgar posted 8 years ago Permalink

You are most probably not running the latest build, as in r5000, we had the same topic. See this thread. So, pressing Esc or clicking the "x" does nothing since then. Please update to the latest build.

But your post makes clear that the message text is not a question which can be answered with yes or no. So I guess it's a good idea to rephrase the big text portion

Unsafe queries found

to some question like

Run unsafe queries?

Code modification/commit from ansgarbecker, 8 years ago, revision 9.3.0.5029
Rephrase confirmation message for running unsafe queries. See http://www.heidisql.com/forum.php?t=20139
ansgar's profile image ansgar posted 8 years ago Permalink

Done in r5029

[expired user #9489]'s profile image [expired user #9489] posted 8 years ago Permalink

Wow thanks much!! I will upgrade right away.

I'm impressed with how much you are able to respond to users requests like this in a timely manner.

Please login to leave a reply, or register at first.