Hotkeys in forms

FeverBeaver's profile image FeverBeaver posted 2 months ago in General Permalink

Hi Ansgar,

Very trivial question and not urgent at all: I noticed that on Linux builds, some hotkeys were not enabled, especially Escape, which should trigger the Cancel button, as it does on Windows version.

As it's basically toggling the "Cancel" property of such button to "True", is that something that will come in v13 (as all platforms will share the same codebase), or is it something users are welcome to contribute & update the repo?

Kind regards, Guillaume

ansgar's profile image ansgar posted 2 months ago Permalink

No I would consider these as bugs in the Linux releases, and I would like to fix them. Feel free to post those you found. Just found one which you probably have in mind: the user manager has a cancel button which does nothing when you press Esc. Looking at that button I see it's a TSpeedButton - likely a bad choice because that does not seem to provide a Cancel property. I should convert these to TBitBtn instead, which provides a cancel property.

FeverBeaver's profile image FeverBeaver posted 2 months ago Permalink

Hi,

I've had a look to the forms in the latest source:

Two forms don't have the Cancel property enabled: frmExportGrid missing loaddataform missing

Buttons that might be set as Cancel: frmEventEditor Discard? frmRoutineEditor Discard? frmTableEditor Discard? frmTableTools Close? frmTriggerEditor Discard? frmView Discard?

And as you said: UserManagerForm: is a TSpeedbutton

Hope this helps.

FeverBeaver's profile image FeverBeaver posted 1 month ago Permalink

Hi Ansgar,

Sorry, looks like all the line breaks have been wiped. Would you mind if I edit the properties and push the changes on git?

Kind regards, Guillaume

FeverBeaver's profile image FeverBeaver posted 1 month ago Permalink

I meant "submit". Not push, I don't (and won't) have any authority on the code.

ansgar's profile image ansgar posted 1 month ago Permalink

Thanks a lot Guillaume! I was quite inactive in the recent weeks here. But I will leave this open in my browser so I should not forget about.

FeverBeaver's profile image FeverBeaver posted 1 month ago Permalink

Else, let me know: I have assigned Cancel where missing, assigned to "Discard" buttons in the forms list above, and changed TSpeedButtons to BitButtons in the user management form.

ansgar's profile image ansgar posted 1 month ago Permalink

I just added that Cancel property to the appropriate buttons on various dialogs. Plus added the Default property on some "OK" buttons.

But I left out the object editor forms with the Discard buttons, as these are not dialogs which can be closed. I recall there were complaints some time ago when these were assigned to Esc, as this discards manual changes too easily.

Please login to leave a reply, or register at first.