[Bug] Comment toggling in procedure edition view doesn't enable the save button (9.4.0.5125)

Xenos's profile image Xenos posted 7 years ago in General Permalink

Hi,

This is a very little non-blocking bug, but still:

  • Create a stored routine, with something like a "SELECT 1" in it
  • Save it
  • Comment the "SELECT 1" by using "--" : "-- SELECT 1", the save button is enabled
  • Save the edited procedure
  • Now, use the keyboard shortcut to toggle the comment on the SELECT
  • The "Save" button remains deactivated

So it seems that toggling comments on one line (or several lines actually) doesn't enable the Save button.

Totally not blocking, because one just have to insert a blank line and remove it, or do whatever useless change like that to enable the Save button, but still, it seems to be a bug.

Code modification/commit 7a48774 from ansgarbecker, 7 years ago, revision 5171
Trigger OnChange event on TSynMemo after toggling comment, so a save button gets enabled. See https://www.heidisql.com/forum.php?t=23834
ansgar's profile image ansgar posted 7 years ago Permalink

Confirmed. And fixed in r5171

ansgar's profile image ansgar posted 7 years ago Permalink

Following commits now support the both "save to textfile" and "un/comment" menu items in the context menus of these "mini" SQL editors.

Please login to leave a reply, or register at first.